Response to code review: #3

rocicorp · Mar 2, 2021 · dc8a01c · dc8a01c
1 parent 1b38c44
commit dc8a01c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/backend/rds.ts b/backend/rds.ts
@@ -80,7 +80,7 @@ export async function transact(body: TransactionBodyFn) {
 export async function ensureDatabase() {
   const result = await executeStatementInDatabase(null, "SHOW DATABASES");
   if (result.records) {
-    if (result.records.find((record) => record[0].stringValue == dbName)) {
+    if (result.records.find((record) => record[0].stringValue === dbName)) {
       // TODO: Maybe migrate version
       return;
     }

diff --git a/frontend/designer.tsx b/frontend/designer.tsx
@@ -23,7 +23,7 @@ export function Designer({ data }: { data: Data }) {
   };
 
   const onMouseMove = (e: MouseEvent) => {
-    if (lastDrag == null) {
+    if (lastDrag === null) {
       return;
     }
     // This is subtle, and worth drawing attention to:

diff --git a/pages/api/replicache-pull.ts b/pages/api/replicache-pull.ts
@@ -9,7 +9,7 @@ export default async (req: NextApiRequest, res: NextApiResponse) => {
   console.log(`Processing pull`, req.body);
 
   const pull = must(pullRequest.decode(req.body));
-  let cookie = pull.baseStateID == "" ? 0 : parseInt(pull.baseStateID);
+  let cookie = pull.baseStateID === "" ? 0 : parseInt(pull.baseStateID);
 
   console.time(`Reading all objects...`);
   let entries;

diff --git a/pages/api/replicache-push.ts b/pages/api/replicache-push.ts
@@ -55,7 +55,8 @@ export default async (req: NextApiRequest, res: NextApiResponse) => {
       console.log({ lastMutationID });
 
       // Scan forward from here collapsing any collapsable mutations.
-      for (let mutation: Mutation; (mutation = push.mutations[i]); i++) {
+      for (; i < push.mutations.length; i++) {
+        let mutation = push.mutations[i];
         console.log({ mutation });
 
         const expectedMutationID = lastMutationID + 1;
@@ -119,7 +120,7 @@ export default async (req: NextApiRequest, res: NextApiResponse) => {
 
 // If prev and next are collapsible, collapse them by mutating next.
 function collapse(prev: Mutation, next: Mutation): boolean {
-  if (prev.name == "moveShape" && next.name == "moveShape") {
+  if (prev.name === "moveShape" && next.name === "moveShape") {
     next.args.dx += prev.args.dx;
     next.args.dy += prev.args.dy;
     return true;