-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rocker/binder basic example gives 'jupyter-notebook' not found error #147
Comments
It may be due to the fact that $ docker run --rm -it rocker/binder pip list
Package Version
---------------------- -----------
aiohttp 3.7.4.post0
anyio 2.2.0
appdirs 1.4.3
argon2-cffi 20.1.0
async-generator 1.10
async-timeout 3.0.1
attrs 20.3.0
bleach 3.3.0
cffi 1.14.5
chardet 4.0.0
defusedxml 0.7.1
distlib 0.3.1
entrypoints 0.3
filelock 3.0.12
GDAL 3.0.4
idna 3.1
importlib-metadata 1.5.0
ipython-genutils 0.2.0
Jinja2 2.11.3
jsonschema 3.2.0
jupyter-client 6.1.12
jupyter-core 4.7.1
jupyter-rsession-proxy 1.2
jupyter-server 1.6.1
jupyter-server-proxy 3.0.2
jupyterlab-pygments 0.1.2
MarkupSafe 1.1.1
mistune 0.8.4
more-itertools 4.2.0
multidict 5.1.0
nbclient 0.5.3
nbconvert 6.0.7
nbformat 5.1.3
nest-asyncio 1.5.1
numpy 1.17.4
packaging 20.9
pandocfilters 1.4.3
pip 21.0.1
prometheus-client 0.10.1
ptyprocess 0.7.0
pycparser 2.20
Pygments 2.8.1
pyparsing 2.4.7
pyrsistent 0.17.3
python-dateutil 2.8.1
pyzmq 22.0.3
Send2Trash 1.5.0
setuptools 56.0.0
simpervisor 0.4
six 1.14.0
sniffio 1.2.0
terminado 0.9.4
testpath 0.4.4
tornado 6.1
traitlets 5.0.5
typing-extensions 3.7.4.3
virtualenv 20.4.3
webencodings 0.5.1
wheel 0.34.2
yarl 1.6.3
zipp 1.0.0 |
I can confirm that it is fixed by changing:
I still don't get a R Kernel in the Jupyter Notebook though and a error (This is all using 4.x R) |
Something is wrong in the way the
and now the R Kernel shows up and works. |
Starting RStudio the errors look like:
Seems like a wrong permissions issue? |
Following @fmannhardt's advice, I dealt with the Does anyone have any advice on how to deal with that problem? |
I have also noticed this issue. Very keen to see discussion of this, there have been issues with RStudio/Binder for ages and I think rocker-versioned2 could be the ideal place to address some of them with solutions that benefit many people. |
Handling pip packages has been a problem for a long time, but now that the wiki records the installed pip packages for each image, I think it's possible to make destructive changes now. |
This issue seems resolved by #309. |
🎉 🎉 Thanks @yuvipanda, @ryanlovett and @eitsupi for all the work here. Very nice to have this fixed, updated in the build scripts and the fixed version automatically deployed. 🚀 |
Yay! Thanks for the merge, @cboettig! Can this issue be closed now? |
probably, I was just waiting to confirm on my end at https://mybinder.org/v2/gh/rocker-org/binder/master?urlpath=rstudio but currently keep seeing timeouts there... ? |
I noticed something similar when I had tried rocker/binder + notebook a week or so ago. I don't think it is binder infrastructure. There was a javascript console error indicating something wrong with an HTTP header, so I suspected one of the jupyter proxy layers. However the proxies worked outside of rocker in a more minimal image. In any case, I still haven't a chance to explore further. |
https://github.com/yuvipanda/rstudio-binder-template works fine for me. I'm 100% convinced that is rocker-org/binder failing because the image was already built, and hence used the older, non-working |
I don't really understand how mybinder works, but comparing https://github.com/yuvipanda/rstudio-binder-template/tree/411ca6a00fc2bd2ed390e23f8bdf439f4d28c128 and https://github.com/rocker-org/binder/tree/82a50434cddf87eb78ec20279120076ed4763be2, the path to the Dockerfile is different. I did not see any option to set the path to the Dockerfile when creating the URL. |
I tried playing with my fork (move the Dockerfile to the root), but I could not get RStudio Server to start... |
This repo no longer builds newer versions of https://hub.docker.com/r/rocker/binder - those come from https://github.com/rocker-org/rocker-versioned2. I've an example template that works in https://github.com/yuvipanda/rocker-binder-template. This repo builds the images where R < 4.x. Needed a few changes to work: 1. Pin to older jupyter-rsession-proxy. Newer version only works with newer RStudio 2. Explicitly install notebook package, as jupyter-rsession-proxy no longer brings that in by default 3. Use jupyter server as the command to start, rather than jupyter notebook. This should have no functional difference, but it means you can remove the notebook package if you don't want to use jupyter notebooks. Ref rocker-org/rocker-versioned2#147
I opened rocker-org/binder#46 to fix that repo. However, newer versions of the binder image are built from this repo, and don't need anything to fix. Maybe the rocker/binder repo should be converted into an example instead? Maybe https://github.com/yuvipanda/rocker-binder-template can be merged into it? |
@yuvipanda yes, that's a great idea! Do you want to send a PR for that? |
I think this issue has been resolved by #309, so I close it. |
I am trying to run the simple example provided on this page:
https://hub.docker.com/r/rocker/binder
It gives the following error:
The text was updated successfully, but these errors were encountered: