added trusted node dao min member count getter

rocket-pool · Feb 24, 2021 · eb77374 · eb77374
1 parent fb7d8ed
commit eb77374
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/dao/trustednode/dao.go b/dao/trustednode/dao.go
@@ -185,6 +185,20 @@ func GetMemberDetails(rp *rocketpool.RocketPool, memberAddress common.Address, o
 }
 
 
+// Get the minimum member count
+func GetMinimumMemberCount(rp *rocketpool.RocketPool, opts *bind.CallOpts) (uint64, error) {
+    rocketDAONodeTrusted, err := getRocketDAONodeTrusted(rp)
+    if err != nil {
+        return 0, err
+    }
+    minMemberCount := new(*big.Int)
+    if err := rocketDAONodeTrusted.Call(opts, minMemberCount, "getMemberMinRequired"); err != nil {
+        return 0, fmt.Errorf("Could not get trusted node DAO minimum member count: %w", err)
+    }
+    return (*minMemberCount).Uint64(), nil
+}
+
+
 // Get the member count
 func GetMemberCount(rp *rocketpool.RocketPool, opts *bind.CallOpts) (uint64, error) {
     rocketDAONodeTrusted, err := getRocketDAONodeTrusted(rp)

diff --git a/tests/dao/trustednode/dao_test.go b/tests/dao/trustednode/dao_test.go
@@ -23,6 +23,13 @@ func TestMemberDetails(t *testing.T) {
     if err := evm.TakeSnapshot(); err != nil { t.Fatal(err) }
     t.Cleanup(func() { if err := evm.RevertSnapshot(); err != nil { t.Fatal(err) } })
 
+    // Get & check minimum member count
+    if minMemberCount, err := trustednodedao.GetMinimumMemberCount(rp, nil); err != nil {
+        t.Error(err)
+    } else if minMemberCount == 0 {
+        t.Error("Incorrect trusted node DAO minimum member count")
+    }
+
     // Get & check initial member details
     if members, err := trustednodedao.GetMembers(rp, nil); err != nil {
         t.Error(err)