Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFS server edits: #1342

Merged
merged 4 commits into from
Jul 12, 2023
Merged

NFS server edits: #1342

merged 4 commits into from
Jul 12, 2023

Conversation

sspencerwire
Copy link
Contributor

@sspencerwire sspencerwire commented Jul 10, 2023

  • remove most (not all) passive voice
  • remove punctuation on bullet points except those under "Case studies" which are a command parameters with a qualifying sentence.
  • some minor wording changes for better understanding (for instance "conserved" becomes "preserves")
  • added Serge to contributors

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

alemorvan and others added 2 commits July 10, 2023 06:21
* Create nfsserver.md

Documentation about nfsserver

* Apply suggestions from code review

Thx @serge

Co-authored-by: Serge Croisé <SergeCroise@users.noreply.github.com>

* Update docs/guides/file_sharing/nfsserver.md

Those darn spaces!

Co-authored-by: Serge Croisé <SergeCroise@users.noreply.github.com>

* Update docs/guides/file_sharing/nfsserver.md

Co-authored-by: Serge Croisé <SergeCroise@users.noreply.github.com>

* Update docs/guides/file_sharing/nfsserver.md

wording change

Co-authored-by: Serge Croisé <SergeCroise@users.noreply.github.com>

* Update nfsserver.md

---------

Co-authored-by: Serge Croisé <SergeCroise@users.noreply.github.com>
Co-authored-by: sspencerwire <sspencerwire@gmail.com>
Co-authored-by: wale soyinka <wsoyinka@gmail.com>
* remove most (not all) passive voice
* remove punctuation on bullet points except those under "Case studies" which are a command parameters with a qualifying sentence.
* some minor wording changes for better understanding (for instance "conserved" becomes "preserves")
* added Serge to contributors
@sspencerwire sspencerwire changed the base branch from nfserver_edit to main July 10, 2023 12:18
Some changes not saved... edited to put them back in.
@sspencerwire
Copy link
Contributor Author

@SergeCroise @alemorvan Please review this. This is the NFS server document with some edits. See commit message for details and then review the content. Feel free to suggest changes as needed.

Co-authored-by: Serge Croisé <SergeCroise@users.noreply.github.com>
@sspencerwire sspencerwire merged commit dd95a28 into rocky-linux:main Jul 12, 2023
1 check passed
@github-actions
Copy link

Test results for a9528ab:

Number of broken URLs: 9

URL,RESULT,FILENAME
 https://raw.githubusercontent.com/ansible/ansible/devel/examples/ansible.cfg,failed,books/learning_ansible/01-basic.md
 https://github.com/ansible/ansible/blob/devel/examples/ansible.cfg,failed,books/learning_ansible/01-basic.md
 https://raw.githubusercontent.com/ansible/ansible/devel/examples/hosts,failed,books/learning_ansible/01-basic.md
 https://github.com/ansible/ansible/blob/devel/examples/hosts,failed,books/learning_ansible/01-basic.md
 http://www.gnu.org/software/hello/hello.html,failed,labs/sys_admin_1/lab7-software_management.md
 https://ersei.saggis.com/,failed,guides/contribute/README.md
 https://github.com/bdacus01,failed,guides/contribute/README.md
 http://www.flaviosiqueira.com.br/,failed,guides/contribute/README.md
 https://github.com/andrewthiesen,failed,guides/contribute/README.md

@sspencerwire sspencerwire deleted the nfserver_edit branch July 20, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants