-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NFS server edits: #1342
Merged
Merged
NFS server edits: #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create nfsserver.md Documentation about nfsserver * Apply suggestions from code review Thx @serge Co-authored-by: Serge Croisé <SergeCroise@users.noreply.github.com> * Update docs/guides/file_sharing/nfsserver.md Those darn spaces! Co-authored-by: Serge Croisé <SergeCroise@users.noreply.github.com> * Update docs/guides/file_sharing/nfsserver.md Co-authored-by: Serge Croisé <SergeCroise@users.noreply.github.com> * Update docs/guides/file_sharing/nfsserver.md wording change Co-authored-by: Serge Croisé <SergeCroise@users.noreply.github.com> * Update nfsserver.md --------- Co-authored-by: Serge Croisé <SergeCroise@users.noreply.github.com> Co-authored-by: sspencerwire <sspencerwire@gmail.com> Co-authored-by: wale soyinka <wsoyinka@gmail.com>
* remove most (not all) passive voice * remove punctuation on bullet points except those under "Case studies" which are a command parameters with a qualifying sentence. * some minor wording changes for better understanding (for instance "conserved" becomes "preserves") * added Serge to contributors
Some changes not saved... edited to put them back in.
@SergeCroise @alemorvan Please review this. This is the NFS server document with some edits. See commit message for details and then review the content. Feel free to suggest changes as needed. |
SergeCroise
suggested changes
Jul 10, 2023
SergeCroise
approved these changes
Jul 11, 2023
Co-authored-by: Serge Croisé <SergeCroise@users.noreply.github.com>
Test results for a9528ab:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author checklist (Completed by original Author)
Rocky Documentation checklist (Completed by Rocky team)