Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md, add links to crowdin #1852

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

SergeCroise
Copy link
Contributor

@SergeCroise SergeCroise commented Mar 1, 2024

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

@SergeCroise SergeCroise marked this pull request as draft March 1, 2024 21:51
@SergeCroise
Copy link
Contributor Author

SergeCroise commented Mar 1, 2024

Hello dear translators,
please review.
@gannazhyrnova , @alexiarstein , @Grammaresque ,
@antoine , @ShyRain , @ambaradan , @wsoyinka

@sspencerwire
Copy link
Contributor

@SergeCroise I totally agree with having the links there, however I think that they need to be better identified, rather than just fitting them into the original sentence structure. Do you want to take another crack at that?? Other opinions are (of course) welcome.

@SergeCroise
Copy link
Contributor Author

SergeCroise commented Mar 1, 2024

@SergeCroise I totally agree with having the links there, however I think that they need to be better identified, rather than just fitting them into the original sentence structure. Do you want to take another crack at that?? Other opinions are (of course) welcome.

@wsoyinka , @sspencerwire
the activity-stream link could also appear in the merge commits of crowdin (commit_message: ).
The aim of this PR is just to illustrate an idea and start the discussion in Mattermost and maybe write an issue to write down what we need and what we want to implement.

i18n:
https://chat.rockylinux.org/rocky-linux/channels/l10n

@sspencerwire
Copy link
Contributor

@SergeCroise I'm basically fine with this. I'm not certain how the activity stream link helps in the meta. We will see if that needs to be removed after. This is a draft at the moment, so if you are ready for it to merge, please convert it to ready for review. ;-)

@SergeCroise SergeCroise marked this pull request as ready for review May 3, 2024 09:06
@SergeCroise
Copy link
Contributor Author

SergeCroise commented May 3, 2024

Please feel free to modify or revert my changes (or close this PR)

@sspencerwire
Copy link
Contributor

I just realized that this was no longer a draft and that it was marked ready to merge. I've got one final question: Have you tested the addition of the link to the meta @SergeCroise ? In other words: Does it work in the web interface (mkdocs)... I can test this to be certain, too.

Copy link

Test results for 945a777:

Number of broken URLs: 5

URL,RESULT,FILENAME
 https://azuremarketplace.microsoft.com/en-us/marketplace/apps/resf.rockylinux-aarch64,failed,guides/cloud/migration-to-new-azure-images.md
 https://www.linuxcapable.com/how-to-install-nginx-mainline-on-rocky-linux/,failed,guides/web/nginx-mainline.md
 https://dl.rockylinux.org/pub/rocky/9.3/live/x86_64/,failed,guides/desktop/kde_installation.md
 https://dl.rockylinux.org/pub/rocky/9.3/live/x86_64/,failed,guides/desktop/mate_installation.md
 https://dl.rockylinux.org/pub/rocky/9.3/live/x86_64/,failed,guides/desktop/xfce_installation.md

@SergeCroise
Copy link
Contributor Author

SergeCroise commented May 29, 2024

Hello
@sspencerwire , @wsoyinka
Please feel free to test, modify or revert my changes.

Copy link
Contributor

@sspencerwire sspencerwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SergeCroise

@sspencerwire sspencerwire merged commit 25b7b21 into rocky-linux:main Jun 3, 2024
3 checks passed
@SergeCroise SergeCroise deleted the patch-54 branch September 6, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants