Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basic_network_configuration.md: add missing white space (tip) #1860

Merged
merged 3 commits into from
Mar 2, 2024
Merged

basic_network_configuration.md: add missing white space (tip) #1860

merged 3 commits into from
Mar 2, 2024

Conversation

SergeCroise
Copy link
Contributor

@SergeCroise SergeCroise commented Mar 2, 2024 •
edited by sspencerwire
Loading

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

sspencerwire
sspencerwire approved these changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@sspencerwire sspencerwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SergeCroise !

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024

Test results for 6863947:

Number of broken URLs: 2

 
URL,RESULT,FILENAME
 https://azure.microsoft.com/en-us/,failed,guides/automation/templates-automation-packer-vsphere.md
 https://www.linode.com/docs/guides/beginners-guide-to-lxd-reverse-proxy,failed,guides/containers/lxd_web_servers.md

@sspencerwire sspencerwire merged commit 20455c9 into rocky-linux:main Mar 2, 2024
3 checks passed
SergeCroise
SergeCroise commented Mar 2, 2024
View reviewed changes
Copy link
Contributor Author

@SergeCroise SergeCroise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sspencerwire please review

docs/guides/network/basic_network_configuration.md
@@ -15,7 +15,7 @@ You can't do much with a computer these days without network connectivity. Wheth
## Prerequisites

* A certain amount of comfort operating from the command line
* Elevated or administrative privileges on the system (For example root, `sudo` and so on)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing comma after sudo or not?

@SergeCroise SergeCroise deleted the patch-55 branch August 25, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sspencerwire sspencerwire sspencerwire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergeCroise @sspencerwire