Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gemstones: Containers: Podman: Fix typos and admonitions #2107

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Gemstones: Containers: Podman: Fix typos and admonitions #2107

merged 5 commits into from
Jun 10, 2024

Conversation

ChrSteinert
Copy link
Contributor

@ChrSteinert ChrSteinert commented Jun 10, 2024 •
edited by sspencerwire
Loading

As discussed.

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

@ChrSteinert ChrSteinert mentioned this pull request Jun 10, 2024
Merged
7 tasks
SergeCroise
SergeCroise reviewed Jun 10, 2024
View reviewed changes
docs/gemstones/containers/podman.md
@@ -75,8 +75,9 @@ To now run your service run:
systemctl --user start nextcloud.service
```

> [!NOTE]
> If you created a file in one of the directories for rootful services, omit the `--user` flag.
!!! note
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
!!! note
!!! note "Note"

SergeCroise
SergeCroise reviewed Jun 10, 2024
View reviewed changes
docs/gemstones/containers/podman.md
@@ -98,8 +99,9 @@ Other file types are supported: pod, volume, network, image and kube. [Pods](htt

Podman additionally provides the `generate systemd` subcommand. It can be used to generate `systemd` service files.

> [!IMPORTANT]
> `generate systemd` is now deprecated and will not receive further features. Usage of Quadlet is recommendet.
!!! warning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
!!! warning
!!! warning "Warning"

Copy link
Contributor

@SergeCroise SergeCroise Jun 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this syntax to make the translation work with crowdin easier
(feel free to modify or revert my changes)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust your experience on that one… And I do not have any opinion on that :D

@ChrSteinert
Copy link
Contributor Author

I will apply those changes to #2108 as well.

@ChrSteinert
Copy link
Contributor Author

I added explicit headers to all the notes. Also in #2108

@sspencerwire
Update podman.md
c884235 
Remove admonition titles in quotes
@sspencerwire
Copy link
Contributor

@ChrSteinert I see that this suggestion came from @SergeCroise, however there was a debate about this within the localization channel of Mattermost, and it was decided then that it was unneeded. If you want to bring that up again, @SergeCroise (in Localization) and see if opinions have changed, I'm fine with that. I think the consensus was that it added another layer of complexity to writing the original English source and wasn't really needed. If that opinion has changed, I'm willing to revisit. Thank you both!

sspencerwire
sspencerwire previously approved these changes Jun 10, 2024
View reviewed changes
@sspencerwire sspencerwire merged commit f5bf91c into rocky-linux:main Jun 10, 2024
2 checks passed
@github-actions GitHub Actions
Copy link

Test results for 5f53d33:

Number of broken URLs: 1

 
URL,RESULT,FILENAME
 https://azuremarketplace.microsoft.com/en-us/marketplace/apps/resf.rockylinux-aarch64,failed,guides/cloud/migration-to-new-azure-images.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeCroise SergeCroise SergeCroise left review comments

@sspencerwire sspencerwire sspencerwire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrSteinert @sspencerwire @SergeCroise