Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper string representations to all classes #477

Closed
roclark opened this issue Sep 26, 2020 · 0 comments · Fixed by #478
Closed

Add proper string representations to all classes #477

roclark opened this issue Sep 26, 2020 · 0 comments · Fixed by #478
Assignees
Labels
bug Something isn't working
Milestone

Comments

@roclark
Copy link
Owner

roclark commented Sep 26, 2020

Describe the bug
The classes need to have a clear string representation in order to allow users to easily view what the objects represent. In many cases, this throws an error while trying to print a class.

To Reproduce

from sportsreference.fb.team import Team

team = Team('Tottenham Hotspur')

print(team)

Expected behavior
The output of printing the team object above should display useful information about the team that it represents, the ID if applicable, and the season.

Desktop (please complete the following information):

  • OS: Ubuntu 18.04 (affects all)
  • Sportsreference Version: 0.5.2 and top of tree
@roclark roclark added the bug Something isn't working label Sep 26, 2020
@roclark roclark added this to the Release 0.6.0 milestone Sep 26, 2020
@roclark roclark self-assigned this Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant