Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string representation for all classes #478

Merged
merged 1 commit into from
Sep 27, 2020
Merged

Conversation

roclark
Copy link
Owner

@roclark roclark commented Sep 26, 2020

All of the methods should have a proper string representation of what the class represents to better allow users to see what the purpose of the class is.

Closes #477

Signed-Off-By: Robert Clark robdclark@outlook.com

@roclark roclark added the bug Something isn't working label Sep 26, 2020
@roclark roclark added this to the Release 0.6.0 milestone Sep 26, 2020
@roclark roclark self-assigned this Sep 26, 2020
@roclark roclark marked this pull request as draft September 26, 2020 00:09
@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #478 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #478    +/-   ##
========================================
  Coverage   99.97%   99.97%            
========================================
  Files          54       54            
  Lines       12771    13004   +233     
========================================
+ Hits        12768    13001   +233     
  Misses          3        3            
Impacted Files Coverage Δ
sportsreference/fb/roster.py 100.00% <100.00%> (ø)
sportsreference/fb/schedule.py 100.00% <100.00%> (ø)
sportsreference/fb/team.py 100.00% <100.00%> (ø)
sportsreference/mlb/boxscore.py 100.00% <100.00%> (ø)
sportsreference/mlb/roster.py 100.00% <100.00%> (ø)
sportsreference/mlb/schedule.py 100.00% <100.00%> (ø)
sportsreference/mlb/teams.py 100.00% <100.00%> (ø)
sportsreference/nba/boxscore.py 100.00% <100.00%> (ø)
sportsreference/nba/roster.py 100.00% <100.00%> (ø)
sportsreference/nba/schedule.py 100.00% <100.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 243956d...3b3aac8. Read the comment docs.

@roclark roclark force-pushed the update-repr-modules branch 13 times, most recently from 31c463e to 7f0aec9 Compare September 26, 2020 23:02
All of the methods should have a proper string representation of what
the class represents to better allow users to see what the purpose of
the class is.

Signed-Off-By: Robert Clark <robdclark@outlook.com>
@roclark roclark marked this pull request as ready for review September 27, 2020 00:28
@roclark roclark merged commit 0ff9c38 into master Sep 27, 2020
@roclark roclark deleted the update-repr-modules branch September 27, 2020 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add proper string representations to all classes
1 participant