Fix issue pulling weight of older NCAAF players #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While attempting to pull player information for players from several seasons ago (tested on 2000 and earlier), sports-reference.com doesn't always contain the player's weight. In this case, their weight will still be set as None, causing an AttributeError to be thrown while attempting to replace the contents of what it expects to be a string. If this situation occurs, the weight should stay as None for the end-user to decide how they want to handle the omission. Signed-Off-By: Robert Clark <robdclark@outlook.com>
roclark
force-pushed
the
patch/fix-legacy-ncaaf-player-weight
branch
from
9d4b3dd
to
923d858
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to pull player information for players from several seasons ago (tested on 2000 and earlier), sports-reference.com doesn't always contain the player's weight. In this case, their weight will still be set as
None, causing anAttributeErrorto be thrown while attempting to replace the contents of what it expects to be a string. If this situation occurs, the weight should stay asNonefor the end-user to decide how they want to handle the omission.Fixes #141
Signed-Off-By: Robert Clark robdclark@outlook.com