Fix issue pulling NCAAF games without time #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the seasons prior to 2013, sports-reference.com does not include a time field in the NCAAF game's information page. This causes the time property to be set to None, which fails while attempting to parse a DateTime between the date and time properties. This behavior can be circumvented by only creating a DateTime of the date as opposed to the date and time when time is None. Signed-Off-By: Robert Clark <robdclark@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the seasons prior to 2013, sports-reference.com does not include a time field in the NCAAF game's information page. This causes the time property to be set to
None, which fails while attempting to parse aDateTimebetween the date and time properties. This behavior can be circumvented by only creating a DateTime of the date as opposed to the date and time when time isNone.Fixes #138
Signed-Off-By: Robert Clark robdclark@outlook.com