Fix issue retrieving data from empty pages #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roclark
force-pushed
the
patch/fix-issue-pulling-teams-with-no-data
branch
from
d933112
to
17b23d0
Compare
Occasionally, such as right before the beginning of a season, a page will return a valid response but will have no data outside of the default HTML and CSS template. With no data present on the page, sportsreference can't parse any information and should indicate the lack of data and return safely. Signed-Off-By: Robert Clark <robdclark@outlook.com>
roclark
force-pushed
the
patch/fix-issue-pulling-teams-with-no-data
branch
from
17b23d0
to
f4f14c7
Compare
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
- Coverage 99.97% 99.82% -0.16%
==========================================
Files 43 43
Lines 9242 9281 +39
==========================================
+ Hits 9240 9265 +25
- Misses 2 16 +14
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, such as right before the beginning of a season, a page will return a valid response but will have no data outside of the default HTML and CSS template. With no data present on the page,
sportsreferencecan't parse any information and should indicate the lack of data and return safely.Fixes #164
Signed-Off-By: Robert Clark robdclark@outlook.com