Add passing_yards to NCAAF players #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The passing_yards attribute was missing for NCAAF players that were retrieved from the Roster module. A link to passing_yards was misplaced and it should have been included in the AbstractPlayer class to ensure it was available everywhere the AbstractPlayer class was inherited. With the property added to the AbstractPlayer class, it is now accessible in the Roster module. Signed-Off-By: Robert Clark <robdclark@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
passing_yardsattribute was missing for NCAAF players that were retrieved from the Roster module. A link topassing_yardswas misplaced and it should have been included in theAbstractPlayerclass to ensure it was available everywhere theAbstractPlayerclass was inherited. With the property added to theAbstractPlayerclass, it is now accessible in the Roster module.Fixes #158
Signed-Off-By: Robert Clark robdclark@outlook.com