Fix issue pulling broken NCAAB player pages #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few links to player pages on www.sports-reference.com are broken which causes errors to be thrown by the LXML parser while attempting to pull them. Since a ParserError is thrown by LXML, we can catch the error and return None to safely continue with execution. Signed-Off-By: Robert Clark <robdclark@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few links to player pages on www.sports-reference.com are broken which causes errors to be thrown by the LXML parser while attempting to pull them. Since a
ParserErroris thrown by LXML, we can catch the error and returnNoneto safely continue with execution.Fixes #115
Signed-Off-By: Robert Clark robdclark@outlook.com