Fix NCAAF conference class for empty pages #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally, a conference page for NCAAF will be an empty document, devoid of any information that can be parsed. When this happens, the Teams class throws an error as it relies on getting information from the Conferences class to determine which conference each team participates in. Instead of attempting to pull the information from other sources, if a conference page isn't valid, any team that participates in that conference should have a conference attribute of None to avoid presenting incorrect information. Signed-Off-By: Robert Clark <robdclark@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
+ Coverage 99.97% 99.97% +<.01%
==========================================
Files 43 43
Lines 9288 9298 +10
==========================================
+ Hits 9286 9296 +10
Misses 2 2
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
+ Coverage 99.97% 99.97% +<.01%
==========================================
Files 43 43
Lines 9288 9298 +10
==========================================
+ Hits 9286 9296 +10
Misses 2 2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, a conference page for NCAAF will be an empty document, devoid of any information that can be parsed. When this happens, the
Teamsclass throws an error as it relies on getting information from theConferencesclass to determine which conference each team participates in. Instead of attempting to pull the information from other sources, if a conference page isn't valid, any team that participates in that conference should have a conference attribute ofNoneto avoid presenting incorrect information.Fixes #179
Signed-Off-By: Robert Clark robdclark@outlook.com