Set default NCAAB time to midnight #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case an NCAAB game doesn't have a time value associated with it, the default time should be set to midnight instead of 7:00PM as users should have the option on how to handle missing data instead of providing false information. Now, users can check if the `time` property is empty and determine how they want to treat the data in such cases. Signed-Off-By: Robert Clark <robdclark@outlook.com>
|
@alokpattani, this update is to resolve what we've discussed in #181. With this patch, users can now run the following (of course, in a more elegant fashion than this, but it gets the idea across): from sportsreference.ncaab.schedule import Schedule
for game in Schedule('PURDUE'):
if not game.time:
# Handling for game not containing valid time goes here |
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 43 43
Lines 9298 9298
=======================================
Hits 9296 9296
Misses 2 2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case an NCAAB game doesn't have a time value associated with it, the default time should be set to midnight instead of 7:00PM as users should have the option on how to handle missing data instead of providing false information. Now, users can check if the
timeproperty is empty and determine how they want to treat the data in such cases.Signed-Off-By: Robert Clark robdclark@outlook.com