Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with boxscores throwing errors #187

Merged
merged 1 commit into from
Sep 7, 2019

Conversation

roclark
Copy link
Owner

@roclark roclark commented Sep 7, 2019

For games that are yet to occur which are listed in an NCAAF team's schedule, an error will be thrown while attempting to parse a score for the game when none exists. To circumvent this issue, not only should the points be checked if they are None, they should also be checked if they are empty.

Fixes #184

Signed-Off-By: Robert Clark robdclark@outlook.com

For games that are yet to occur which are listed in an NCAAF team's
schedule, an error will be thrown while attempting to parse a score for
the game when none exists. To circumvent this issue, not only should the
points be checked if they are None, they should also be checked if they
are empty.

Signed-Off-By: Robert Clark <robdclark@outlook.com>
@roclark roclark added the bug Something isn't working label Sep 7, 2019
@roclark roclark added this to the Release 0.4.4 milestone Sep 7, 2019
@roclark roclark self-assigned this Sep 7, 2019
@roclark roclark merged commit d82abf4 into master Sep 7, 2019
@roclark roclark deleted the patch/fix-invalid-ncaaf-games branch September 7, 2019 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NCAAF Current season (2019) teams.schedule.dataframe_extended is NoneType
1 participant