-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add defensive stats to NCAAF teams #194
Add defensive stats to NCAAF teams #194
Conversation
824b0cf
to
1356cb9
Compare
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
==========================================
+ Coverage 99.97% 99.97% +<.01%
==========================================
Files 43 43
Lines 9299 9365 +66
==========================================
+ Hits 9297 9363 +66
Misses 2 2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely wonderful work @ajhodges! This is incredible and adds a lot of valuable content to the repository! I just added a couple of very minor clarification questions, but otherwise this looks great and I'm happy to merge it! I have another bug I want to sort out with the project, but once complete, I will spin a new release to make sure this gets out for the rest of the community.
Thanks again!
1356cb9
to
77385d6
Compare
I noticed that your recent commit is now failing the Travis checks... Not really sure what happened since your changes are completely unrelated to the failing test, but I will dive into this and see why this is happening. |
On further investigation, master is also failing, so the issue with the tests is definitely not related to your update. I will try and get a fix out to make sure this is passing, but otherwise I have no issue here and am happy to merge it! Thanks again for pushing this out! |
Applied a fix and now everything is looking good here, so I will go ahead and merge! Thanks again for the great work! 🥇 |
opponents_pass_completions
opponents_pass_attempts
opponents_pass_completion_percentage
opponents_pass_yards
opponents_interceptions
opponents_pass_touchdowns
opponents_rush_attempts
opponents_rush_yards
opponents_rush_yards_per_attempt
opponents_rush_touchdowns
opponents_plays
opponents_yards
opponents_turnovers
opponents_fumbles_lost
opponents_yards_per_play
opponents_pass_first_downs
opponents_rush_first_downs
opponents_first_downs_from_penalties
opponents_first_downs
opponents_penalties
opponents_yards_from_penalties
_retrieve_all_teams
to merge defensive stats with conference/offensive stats.Closes #193