Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Peru in MLB #212

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Add support for Peru in MLB #212

merged 1 commit into from
Oct 3, 2019

Conversation

roclark
Copy link
Owner

@roclark roclark commented Oct 2, 2019

Jesus Luzardo becomes the first MLB player from Peru. As a result, support should be added for Peru in the list of nationalities.

Fixes #211

Signed-Off-By: Robert Clark robdclark@outlook.com

Jesus Luzardo becomes the first MLB player from Peru. As a result,
support should be added for Peru in the list of nationalities.

Signed-Off-By: Robert Clark <robdclark@outlook.com>
@roclark roclark added the bug Something isn't working label Oct 2, 2019
@roclark roclark added this to the Release 0.5.0 milestone Oct 2, 2019
@roclark roclark self-assigned this Oct 2, 2019
@codecov
Copy link

codecov bot commented Oct 2, 2019

Codecov Report

Merging #212 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files          42       42           
  Lines        9356     9356           
=======================================
  Hits         9354     9354           
  Misses          2        2
Impacted Files Coverage Δ
sportsreference/mlb/constants.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d18ba80...f90b55a. Read the comment docs.

@roclark roclark merged commit 7f8e962 into master Oct 3, 2019
@roclark roclark deleted the patch/add-mlb-nationalities branch October 3, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for additional nationalities in MLB
1 participant