Resolve errors while pulling empty NBA stats pages #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 42 42
Lines 9357 9361 +4
=======================================
+ Hits 9355 9359 +4
Misses 2 2
Continue to review full report at Codecov.
|
roclark
force-pushed
the
patch/fix-nba-player-null-pages
branch
from
1bea117
to
02965de
Compare
Some players don't have a personal stats page created for them yet, but contain a valid link on roster pages. As implemented, the Roster module for the NBA does not check if the returned data from the page is empty, and will attempt to parse information from an object which is None. Instead, if a player's page is invalid, the module should fail-fast and return None for the player instead of attempting to parse information or handle other scenarios. Signed-Off-By: Robert Clark <robdclark@outlook.com>
roclark
force-pushed
the
patch/fix-nba-player-null-pages
branch
from
02965de
to
c237881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some players don't have a personal stats page created for them yet, but contain a valid link on roster pages. As implemented, the Roster module for the NBA does not check if the returned data from the page is empty, and will attempt to parse information from an object which is
None. Instead, if a player's page is invalid, the module should fail-fast and returnNonefor the player instead of attempting to parse information or handle other scenarios.Fixes #217
Signed-Off-By: Robert Clark robdclark@outlook.com