Fix issue pulling empty NBA roster fields #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
==========================================
+ Coverage 99.97% 99.97% +<.01%
==========================================
Files 42 42
Lines 9361 9362 +1
==========================================
+ Hits 9359 9360 +1
Misses 2 2
Continue to review full report at Codecov.
|
roclark
force-pushed
the
patch/fix-empty-nba-roster-fields
branch
3 times, most recently
from
68e8049
to
c1fbfb6
Compare
Occasionally, some NBA roster pages will include empty rows in the roster table, causing the code to think another player exists when one doesn't, throwing an error when it is unable to parse a player ID. If an empty row is ever encountered, it should just be skipped as no information can be parsed anyway. Signed-Off-By: Robert Clark <robdclark@outlook.com>
roclark
force-pushed
the
patch/fix-empty-nba-roster-fields
branch
from
c1fbfb6
to
f5c324c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, some NBA roster pages will include empty rows in the roster table, causing the code to think another player exists when one doesn't, throwing an error when it is unable to parse a player ID. If an empty row is ever encountered, it should just be skipped as no information can be parsed anyway.
Fixes #226
Signed-Off-By: Robert Clark robdclark@outlook.com