Fix incorrect home records in NBA boxscores #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roclark
force-pushed
the
patch/fix-nba-records
branch
from
9a2e0f2
to
04c6c33
Compare
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
==========================================
+ Coverage 99.96% 99.96% +<.01%
==========================================
Files 42 42
Lines 9366 9371 +5
==========================================
+ Hits 9363 9368 +5
Misses 3 3
Continue to review full report at Codecov.
|
The NBA Boxscore class was pulling the incorrect home record in some scenarios. Instead of picking a particular index, the home team's record should be the final index as a non-deterministic amount of records could be displayed on a page, but the home team will always be last. Signed-Off-By: Robert Clark <robdclark@outlook.com>
roclark
force-pushed
the
patch/fix-nba-records
branch
from
04c6c33
to
6bcd9b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NBA Boxscore class was pulling the incorrect home record in some scenarios. Instead of picking a particular index, the home team's record should be the final index as a non-deterministic amount of records could be displayed on a page, but the home team will always be last.
Fixes #230
Signed-Off-By: Robert Clark robdclark@outlook.com