Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add game summary for NFL boxscores #287

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Add game summary for NFL boxscores #287

merged 1 commit into from
Nov 29, 2019

Conversation

roclark
Copy link
Owner

@roclark roclark commented Nov 29, 2019

A game summary including a quarter-by-quarter score should be included as an attribute to the NFL Boxscores class, which returns a dictionary of both the home and away team's score per quarter, including any overtime results.

Closes #286

Signed-Off-By: Robert Clark robdclark@outlook.com

A game summary including a quarter-by-quarter score should be included
as an attribute to the NFL Boxscores class, which returns a dictionary
of both the home and away team's score per quarter, including any
overtime results.

Signed-Off-By: Robert Clark <robdclark@outlook.com>
@roclark roclark added the enhancement New feature or request label Nov 29, 2019
@roclark roclark added this to the Release 0.5.0 milestone Nov 29, 2019
@roclark roclark self-assigned this Nov 29, 2019
@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #287 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
+ Coverage   99.96%   99.96%   +<.01%     
==========================================
  Files          42       42              
  Lines        9452     9472      +20     
==========================================
+ Hits         9449     9469      +20     
  Misses          3        3
Impacted Files Coverage Δ
sportsreference/nfl/constants.py 100% <ø> (ø) ⬆️
sportsreference/nfl/boxscore.py 99.78% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9f1ce1...a1ba3f6. Read the comment docs.

@roclark roclark merged commit baa4890 into master Nov 29, 2019
@roclark roclark deleted the add-game-summaries branch November 29, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NFL Boxscores
1 participant