Add game summary for NBA boxscores #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
==========================================
+ Coverage 99.96% 99.96% +<.01%
==========================================
Files 42 42
Lines 9472 9491 +19
==========================================
+ Hits 9469 9488 +19
Misses 3 3
Continue to review full report at Codecov.
|
A game summary including a quarter-by-quarter score should be included as an attribute to the NBA Boxscores class, which returns a dictionary of both the home and away team's score per quarter, including any overtime results. Signed-Off-By: Robert Clark <robdclark@outlook.com>
roclark
force-pushed
the
add-game-summaries
branch
from
13ea070
to
9e3ee6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A game summary including a quarter-by-quarter score should be included as an attribute to the NBA Boxscores class, which returns a dictionary of both the home and away team's score per quarter, including any overtime results.
Closes #302
Signed-Off-By: Robert Clark robdclark@outlook.com