Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add game summary for MLB boxscores #307

Merged
merged 1 commit into from
Dec 25, 2019
Merged

Add game summary for MLB boxscores #307

merged 1 commit into from
Dec 25, 2019

Conversation

roclark
Copy link
Owner

@roclark roclark commented Dec 24, 2019

A game summary including a inning-by-inning score should be included as an attribute to the MLB Boxscores class, which returns a dictionary of both the home and away team's score per half, including any extra inning results.

Closes #306

Signed-Off-By: Robert Clark robdclark@outlook.com

@roclark roclark added the enhancement New feature or request label Dec 24, 2019
@roclark roclark added this to the Release 0.5.0 milestone Dec 24, 2019
@roclark roclark self-assigned this Dec 24, 2019
@codecov
Copy link

codecov bot commented Dec 24, 2019

Codecov Report

Merging #307 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   99.96%   99.96%   +<.01%     
==========================================
  Files          42       42              
  Lines        9510     9531      +21     
==========================================
+ Hits         9507     9528      +21     
  Misses          3        3
Impacted Files Coverage Δ
sportsreference/mlb/constants.py 100% <ø> (ø) ⬆️
sportsreference/mlb/boxscore.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39b87d6...2dc40df. Read the comment docs.

A game summary including a inning-by-inning score should be included as
an attribute to the MLB Boxscores class, which returns a dictionary of
both the home and away team's score per half, including any extra inning
results.

Signed-Off-By: Robert Clark <robdclark@outlook.com>
@roclark roclark merged commit 2e237f0 into master Dec 25, 2019
@roclark roclark deleted the add-game-summaries branch December 30, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MLB scoring summary to Boxscores
1 participant