Fix issue pulling missing NCAAB player weight #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally, some NCAAB players will not have a weight listed on their stats page on sports-reference.com. This will return `None` for the property in the Player class. While attempting to parse the weight from None, an error will be thrown. Doing a simple check to see if the weight is valid prior to parsing will resolve the issue and allow execution as expected. Signed-Off-By: Robert Clark <robdclark@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #357 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 48 48
Lines 10547 10549 +2
=======================================
+ Hits 10544 10546 +2
Misses 3 3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, some NCAAB players will not have a weight listed on their stats page on sports-reference.com. This will return
Nonefor the property in the Player class. While attempting to parse the weight from None, an error will be thrown. Doing a simple check to see if the weight is valid prior to parsing will resolve the issue and allow execution as expected.Fixes #298
Signed-Off-By: Robert Clark robdclark@outlook.com