Fix issue pulling empty NBA roster page #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally, an NBA team's roster page on sports-reference.com will be empty, causing an error to be thrown while attempting to parse the page. Adding an additional check to see if the page is parsable will gracefully handle situations where the page is invalid. Signed-Off-By: Robert Clark <robdclark@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 48 48
Lines 10549 10549
=======================================
Hits 10546 10546
Misses 3 3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, an NBA team's roster page on sports-reference.com will be empty, causing an error to be thrown while attempting to parse the page. Adding an additional check to see if the page is parsable will gracefully handle situations where the page is invalid.
Fixes #337
Signed-Off-By: Robert Clark robdclark@outlook.com