Skip NCAAB teams without stat pages #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2010 and earlier years, some NCAAB teams, such as Bryant University, made the transition from Division-II or lower to Division-I basketball. This caused an issue on the website as sometimes those teams would be displayed in the overall school stats, but they would not have their own standalone stats page specific to their school. This would prevent the code from parsing the team's conference and other stats, and would throw an error while attempting to instantiate the team. Doing a simple check to see if the team exists in the conference dataset prior to checking instantiating the team mitigates this issue. Signed-Off-By: Robert Clark <robdclark@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
========================================
Coverage 99.97% 99.97%
========================================
Files 48 48
Lines 10549 10692 +143
========================================
+ Hits 10546 10689 +143
Misses 3 3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2010 and earlier years, some NCAAB teams, such as Bryant University, made the transition from Division-II or lower to Division-I basketball. This caused an issue on the website as sometimes those teams would be displayed in the overall school stats, but they would not have their own standalone stats page specific to their school. This would prevent the code from parsing the team's conference and other stats, and would throw an error while attempting to instantiate the team. Doing a simple check to see if the team exists in the conference dataset prior to checking instantiating the team mitigates this issue.
Fixes #365
Signed-Off-By: Robert Clark robdclark@outlook.com