Fix issue pulling NFL rosters #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain NFL rosters contain links to individual player pages that are either invalid or incomplete, causing an error during the parsing step. This occurs more frequently with earlier seasons as many pages were invalid. Simply checking if a page is invalid prior to attempting to parse the information will prevent the error from being thrown, and allow expected execution to continue. Signed-Off-By: Robert Clark <robdclark@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #377 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 48 48
Lines 10551 10551
=======================================
Hits 10548 10548
Misses 3 3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain NFL rosters contain links to individual player pages that are either invalid or incomplete, causing an error during the parsing step. This occurs more frequently with earlier seasons as many pages were invalid. Simply checking if a page is invalid prior to attempting to parse the information will prevent the error from being thrown, and allow expected execution to continue.
Fixes #376
Signed-Off-By: Robert Clark robdclark@outlook.com