Fix issue pulling football schedules and rosters #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the Team class for football is unable to pull a team's page, the document for the team will be invalid, and the '_doc' attribute will not exist for that team. While trying to pull the schedule or roster for that team, an error will be thrown that the '_doc' attribute does not exist. Simply checking if the attribute exists, and setting it to None if not will allow the Schedule and Roster modules to retry pulling the page again to see if it works. Signed-Off-By: Robert Clark <robdclark@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #392 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 48 48
Lines 10578 10582 +4
=======================================
+ Hits 10575 10579 +4
Misses 3 3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Team class for football is unable to pull a team's page, the document for the team will be invalid, and the '_doc' attribute will not exist for that team. While trying to pull the schedule or roster for that team, an error will be thrown that the '_doc' attribute does not
exist.
Simply checking if the attribute exists, and setting it to
Noneif not will allow the Schedule and Roster modules to retry pulling the page again to see if it works.Fixes #391
Signed-Off-By: Robert Clark robdclark@outlook.com