Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datetime property to NFL boxscores #398

Merged
merged 1 commit into from
Apr 12, 2020
Merged

Conversation

roclark
Copy link
Owner

@roclark roclark commented Apr 12, 2020

The NFL boxscores class needs a datetime property comprised of both the date and time of the game to allow easier referencing of games in a schedule.

Fixes #384

Signed-Off-By: Robert Clark robdclark@outlook.com

The NFL boxscores class needs a datetime property comprised of both the
date and time of the game to allow easier referencing of games in a
schedule.

Signed-Off-By: Robert Clark <robdclark@outlook.com>
@roclark roclark added the enhancement New feature or request label Apr 12, 2020
@roclark roclark added this to the Release 0.6.0 milestone Apr 12, 2020
@roclark roclark self-assigned this Apr 12, 2020
@codecov
Copy link

codecov bot commented Apr 12, 2020

Codecov Report

Merging #398 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files          48       48           
  Lines       10574    10582    +8     
=======================================
+ Hits        10571    10579    +8     
  Misses          3        3           
Impacted Files Coverage Δ
sportsreference/nfl/boxscore.py 99.78% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5dd33d...cd4666e. Read the comment docs.

@roclark roclark merged commit 32cc99f into master Apr 12, 2020
@roclark roclark deleted the add-time-to-nfl-datetime branch April 12, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Time to Schedule Dataframes
1 participant