Enable NCAAF Team to be directly accessible #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roclark
force-pushed
the
direct-ncaaf-team-module
branch
4 times, most recently
from
f2831b5
to
b4c9999
Compare
Instead of requiring users to go through the Teams class to get a specific team, the NCAAF modules now enable a specific team to be directly queried by using the Team class. This reduces computational complexity by removing the need to instantiate every team while also making it more intuitive for users. Signed-Off-By: Robert Clark <robdclark@outlook.com>
roclark
force-pushed
the
direct-ncaaf-team-module
branch
from
b4c9999
to
8f6eb9a
Compare
Codecov Report
@@ Coverage Diff @@
## master #405 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 51 52 +1
Lines 10665 10683 +18
=======================================
+ Hits 10662 10680 +18
Misses 3 3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of requiring users to go through the Teams class to get a specific team, the NCAAF modules now enable a specific team to be directly queried by using the Team class. This reduces computational complexity by removing the need to instantiate every team while also
making it more intuitive for users.
Related to #360
Signed-Off-By: Robert Clark robdclark@outlook.com