Enable NFL Team to be directly accessible #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roclark
force-pushed
the
direct-nfl-team-module
branch
2 times, most recently
from
79f7ded
to
ae95c47
Compare
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 52 53 +1
Lines 10683 10699 +16
=======================================
+ Hits 10680 10696 +16
Misses 3 3
Continue to review full report at Codecov.
|
Instead of requiring users to go through the Teams class to get a specific team, the NFL modules now enable a specific team to be directly queried by using the Team class. This reduces computational complexity by removing the need to instantiate every team while also making it more intuitive for users. Signed-Off-By: Robert Clark <robdclark@outlook.com>
roclark
force-pushed
the
direct-nfl-team-module
branch
from
ae95c47
to
959ab23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of requiring users to go through the Teams class to get a specific team, the NFL modules now enable a specific team to be directly queried by using the Team class. This reduces computational complexity by removing the need to instantiate every team while also making it more intuitive for users.
Related to #360
Signed-Off-By: Robert Clark robdclark@outlook.com