Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advanced rushing and receiving stats for NFL #410

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

roclark
Copy link
Owner

@roclark roclark commented Apr 26, 2020

The NFL should include advanced rushing and receiving stats, such as yards before contact, drop percentage, broken tackles, and more to provide more depth to the metrics included with the API.

Closes #290

Signed-Off-By: Robert Clark robdclark@outlook.com

@roclark roclark added the enhancement New feature or request label Apr 26, 2020
@roclark roclark added this to the Release 0.6.0 milestone Apr 26, 2020
@roclark roclark self-assigned this Apr 26, 2020
@codecov
Copy link

codecov bot commented Apr 26, 2020

Codecov Report

Merging #410 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #410   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files          54       54           
  Lines       12617    12703   +86     
=======================================
+ Hits        12614    12700   +86     
  Misses          3        3           
Impacted Files Coverage Δ
sportsreference/nfl/player.py 100.00% <ø> (ø)
sportsreference/nfl/constants.py 100.00% <100.00%> (ø)
sportsreference/nfl/roster.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 189766f...6c137ce. Read the comment docs.

@roclark roclark force-pushed the add-nfl-advanced-rushing-receiving branch from f9cb09f to daabc47 Compare April 26, 2020 20:45
@roclark roclark force-pushed the add-nfl-advanced-rushing-receiving branch 5 times, most recently from 0e37085 to bab34e0 Compare September 25, 2020 03:27
The NFL should include advanced rushing and receiving stats, such as
yards before contact, drop percentage, broken tackles, and more to
provide more depth to the metrics included with the API.

Signed-Off-By: Robert Clark <robdclark@outlook.com>
@roclark roclark force-pushed the add-nfl-advanced-rushing-receiving branch from bab34e0 to 6c137ce Compare September 25, 2020 12:41
@roclark roclark merged commit 2ec7ef7 into master Sep 25, 2020
@roclark roclark deleted the add-nfl-advanced-rushing-receiving branch September 25, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A way to get Advanced rushing and receiving stats?
1 participant