Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Per 100 Possessions stats to NBA #476

Merged
merged 1 commit into from
Sep 26, 2020
Merged

Conversation

roclark
Copy link
Owner

@roclark roclark commented Sep 25, 2020

In addition to the overall career and season stats for NBA players, stats per 100 possessions should also be included to represent each player's efficiency while on the court. This is especially crucial to compare players that might have vastly differing amounts of playtime.

Fixes #257

Signed-Off-By: Robert Clark robdclark@outlook.com

@roclark roclark added the enhancement New feature or request label Sep 25, 2020
@roclark roclark added this to the Release 0.6.0 milestone Sep 25, 2020
@roclark roclark self-assigned this Sep 25, 2020
@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #476 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #476   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files          54       54           
  Lines       12703    12771   +68     
=======================================
+ Hits        12700    12768   +68     
  Misses          3        3           
Impacted Files Coverage Δ
sportsreference/nba/constants.py 100.00% <ø> (ø)
sportsreference/nba/roster.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ec7ef7...ddeb988. Read the comment docs.

In addition to the overall career and season stats for NBA players,
stats per 100 possessions should also be included to represent each
player's efficiency while on the court. This is especially crucial to
compare players that might have vastly differing amounts of playtime.

Signed-Off-By: Robert Clark <robdclark@outlook.com>
@roclark roclark merged commit 243956d into master Sep 26, 2020
@roclark roclark deleted the add-nba-per-100-posession branch September 26, 2020 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per 100 Posessions
1 participant