Fix issues pulling default NBA year for 2020 #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 55 55
Lines 13006 13023 +17
=======================================
+ Hits 13003 13020 +17
Misses 3 3
Continue to review full report at Codecov.
|
Given the lengthy delays to the NBA season in 2020, attempting to pull the NBA modules towards the end of the calendar year throws off the logic as the default logic assumes the next season is either getting ready to start or is already underway. In 2020, however, this has not yet happened, and an HTTPError will be thrown while attempting to pull the stats without specifying the year. By doing a one-off check for 2020, a handler can be made to identify whether or not the next season has started yet. This will only be applicable for the second half of 2020, and can be removed at a later date. Signed-Off-By: Robert Clark <robdclark@outlook.com>
roclark
force-pushed
the
fix-nba-default-season-2020
branch
from
7d7fc02
to
2a3be27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the lengthy delays to the NBA season in 2020, attempting to pull the NBA modules towards the end of the calendar year throws off the logic as the default logic assumes the next season is either getting ready to start or is already underway. In 2020, however, this has not yet happened, and an
HTTPErrorwill be thrown while attempting to pull the stats without specifying the year. By doing a one-off check for 2020, a handler can be made to identify whether or not the next season has started yet. This will only be applicable for the second half of 2020, and can be removed at a later date.Fixes #464
Signed-Off-By: Robert Clark robdclark@outlook.com