Fix NBA home team score in Boxscore #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Boxscore class was producing the incorrect score for the home team, and instead was pulling the home team's second half points total. By reading the score directly from the header, the chances of running into a parsing issue are much lower in case the layout changes again on the website. Signed-Off-By: Robert Clark <robdclark@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 55 55
Lines 13023 13023
=======================================
Hits 13020 13020
Misses 3 3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Boxscoreclass was producing the incorrect score for the home team, and instead was pulling the home team's second half points total. By reading the score directly from the header, the chances of running into a parsing issue are much lower in case the layout changes again on the website.Fixes #470
Signed-Off-By: Robert Clark robdclark@outlook.com