Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NCAAF boxscores showing incorrect teams #504

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Conversation

roclark
Copy link
Owner

@roclark roclark commented Oct 15, 2020

Occasionally, the incorrect team would be listed in the NCAAF Boxscores module, which would occur when the date would be listed in the boxscore instead of just the teams and scores. This caused the home team to be incorrectly listed as both the home and away team.

Fixes #499

Signed-Off-By: Robert Clark robdclark@outlook.com

Occasionally, the incorrect team would be listed in the NCAAF Boxscores
module, which would occur when the date would be listed in the boxscore
instead of just the teams and scores. This caused the home team to be
incorrectly listed as both the home and away team.

Signed-Off-By: Robert Clark <robdclark@outlook.com>
@roclark roclark added the bug Something isn't working label Oct 15, 2020
@roclark roclark added this to the Release 0.6.0 milestone Oct 15, 2020
@roclark roclark self-assigned this Oct 15, 2020
@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #504 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #504   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files          55       55           
  Lines       13082    13084    +2     
=======================================
+ Hits        13079    13081    +2     
  Misses          3        3           
Impacted Files Coverage Δ
sportsreference/ncaaf/boxscore.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77c536...4d5ce11. Read the comment docs.

@roclark roclark merged commit 8207956 into master Oct 15, 2020
@roclark roclark deleted the fix-ncaaf-boxscores branch October 15, 2020 22:22
@roclark roclark added the hacktoberfest-accepted Recommended issues or pull requests for Hacktoberfest label Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest-accepted Recommended issues or pull requests for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NCAAF multiple boxscores does not scrape correctly when on certain date
1 participant