Fix NFL players wrongly being listed as away #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally, some NFL Boxscores would incorrectly list the home team players as away. This is caused by the home and away teams using different abbreviations in their URIs than the abbreviations listed in the tables, which would fail the branching logic to select the players for a specific team. By checking the abbreviations listed on the actual page outside of the URIs, the players can be placed properly into one team or the other. Signed-Off-By: Robert Clark <robdclark@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #507 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 55 55
Lines 13094 13106 +12
=======================================
+ Hits 13091 13103 +12
Misses 3 3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, some NFL Boxscores would incorrectly list the home team players as away. This is caused by the home and away teams using different abbreviations in their URIs than the abbreviations listed in the tables, which would fail the branching logic to select the players for a specific team.
By checking the abbreviations listed on the actual page outside of the URIs, the players can be placed properly into one team or the other.
Fixes #501
Signed-Off-By: Robert Clark robdclark@outlook.com