Fix issue pulling football league positions #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roclark
force-pushed
the
fix-fb-position
branch
from
02a3d5c
to
a2be3d3
Compare
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 55 55
Lines 13168 13171 +3
=======================================
+ Hits 13165 13168 +3
Misses 3 3
Continue to review full report at Codecov.
|
Occasionally, a team's league position will not be posted on their team page, throwing an error while attempting to parse that information. Defaulting the value to None in this scenario will skip the error while allowing expected functionality to continue. Signed-Off-By: Robert Clark <robdclark@outlook.com>
roclark
force-pushed
the
fix-fb-position
branch
from
a2be3d3
to
20d3ec0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, a team's league position will not be posted on their team page, throwing an error while attempting to parse that information. Defaulting the value to
Nonein this scenario will skip the error while allowing expected functionality to continue.Fixes #530
Signed-Off-By: Robert Clark robdclark@outlook.com