Fix issue pulling future NFL boxscores #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #529 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 55 55
Lines 13168 13259 +91
=======================================
+ Hits 13165 13256 +91
Misses 3 3
Continue to review full report at Codecov.
|
For NFL games that are scheduled but have not yet taken place, the code would take the preview link for the game and treat it as the Boxscore link, causing errors to be thrown while attempt to pull Boxscore data from the preview which doesn't have the intended information. Signed-Off-By: Robert Clark <robdclark@outlook.com>
roclark
force-pushed
the
fix-nfl-boxscore-pulling
branch
from
5f5fe73
to
7c6d18f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For NFL games that are scheduled but have not yet taken place, the code would take the preview link for the game and treat it as the Boxscore link, causing errors to be thrown while attempt to pull Boxscore data from the preview which doesn't have the intended information.
Fixes #531
Signed-Off-By: Robert Clark robdclark@outlook.com