Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect squad IDs for football #535

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Fix incorrect squad IDs for football #535

merged 1 commit into from
Nov 13, 2020

Conversation

roclark
Copy link
Owner

@roclark roclark commented Nov 13, 2020

Some teams had the incorrect squad IDs in the football section, making it appear they didn't exist.

Fixes #515

Signed-Off-By: Robert Clark robdclark@outlook.com

Some teams had the incorrect squad IDs in the football section, making
it appear they didn't exist.

Signed-Off-By: Robert Clark <robdclark@outlook.com>
@roclark roclark added the bug Something isn't working label Nov 13, 2020
@roclark roclark added this to the Release 0.6.0 milestone Nov 13, 2020
@roclark roclark self-assigned this Nov 13, 2020
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #535 (b33099f) into master (77d64a1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #535   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files          55       55           
  Lines       13178    13178           
=======================================
  Hits        13175    13175           
  Misses          3        3           
Impacted Files Coverage Δ
sportsreference/fb/squad_ids.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77d64a1...b33099f. Read the comment docs.

@roclark roclark merged commit 2c3d5f9 into master Nov 13, 2020
@roclark roclark deleted the fix-fb-ids branch November 14, 2020 15:01
Copy link

@faithfu1 faithfu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should change Arsenal id and Arsenal Women ID because they are the same and whenever i use "Arsenal", it always refers back to Arsenal Womens please change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Football - Premiere League Male Teams / Squad_ids missing
2 participants