Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode NCAAB player names #567

Merged
merged 1 commit into from
Jan 1, 2021
Merged

Encode NCAAB player names #567

merged 1 commit into from
Jan 1, 2021

Conversation

roclark
Copy link
Owner

@roclark roclark commented Jan 1, 2021

Windows is unable to handle certain NCAAB player names in the exhaustive tests, and need to be specially handled.

Signed-Off-By: Robert Clark robdclark@outlook.com

Windows is unable to handle certain NCAAB player names in the exhaustive
tests, and need to be specially handled.

Signed-Off-By: Robert Clark <robdclark@outlook.com>
@roclark roclark added the bug Something isn't working label Jan 1, 2021
@roclark roclark added this to the Release 0.6.0 milestone Jan 1, 2021
@roclark roclark self-assigned this Jan 1, 2021
@codecov
Copy link

codecov bot commented Jan 1, 2021

Codecov Report

Merging #567 (76b3b30) into master (8fed6ad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #567   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files          55       55           
  Lines       13178    13178           
=======================================
  Hits        13175    13175           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fed6ad...76b3b30. Read the comment docs.

@roclark roclark merged commit 16b00b9 into master Jan 1, 2021
@roclark roclark deleted the encode-ncaab-tests branch January 1, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant