Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use forgeapi.puppetlabs.com and API v3 #210

Closed
domcleal opened this issue May 6, 2014 · 5 comments
Closed

Update to use forgeapi.puppetlabs.com and API v3 #210

domcleal opened this issue May 6, 2014 · 5 comments

Comments

@domcleal
Copy link

domcleal commented May 6, 2014

I'm running librarian-puppet 1.0.1 and Puppet 3.6.0-rc1 (the git tag, currently unreleased), but am hitting problems with the migration from forge.puppetlabs.com to forgeapi.puppetlabs.com, and the v1 to v3 API switch.

  1. In the same vein as bd29b9f, the client_api_version method should return v3 for Puppet 3.6 or higher.
  2. Changing the Forge URL in Puppetfile to https://forgeapi.puppetlabs.com fails too, as librarian-puppet tries to query https://forgeapi.puppetlabs.com/api/v1/releases.json?module=puppetlabs/mysql. The /api prefix needs removing.

Any thoughts on the best way to implement part (2)? Forcing users to add /api to their existing Forge URLs would be incompatible, so perhaps detecting the URL is best and then adding/removing /api as applicable... Or perhaps if Puppet Labs redirected /api to / on forgeapi.pl.com, compatibility could be maintained and in future, the path should be added to the Forge URL in the Puppetfile. (@ryanycoleman)

@adreyer
Copy link

adreyer commented May 7, 2014

Part 2 should ultimately be dealt with by moving librarian puppet to use the v3 forge API. What is uses now is being deprecated with puppet 3.6.0 .

@domcleal domcleal changed the title Puppet 3.6 and forgeapi/v3 compatibility Update to use forgeapi.puppetlabs.com and API v3 May 8, 2014
@domcleal
Copy link
Author

domcleal commented May 8, 2014

Makes sense, I've updated the issue title so this is just a request to move over to the new v3 API and forgeapi.pl.com consistently.

@carlossg
Copy link
Collaborator

There's a new ruby gem to interact with the V3 API https://github.com/puppetlabs/forge-ruby

carlossg pushed a commit that referenced this issue Jun 9, 2014
puppet_forge requires ruby 1.9 so we do too
Use API v3 only for official puppetlabs repo
Puppet 2 can't handle the 302 returned by the https url, so stick to http
@carlossg
Copy link
Collaborator

Using v3 in 1.1.0

@mfowlewebs
Copy link

Is there any reason to stay on v1? Should v3 be made the default at some point, and when would be the time to consider that change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants