Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use a custom v3 forge #237

Closed
jhaals opened this issue Jul 16, 2014 · 0 comments
Closed

Unable to use a custom v3 forge #237

jhaals opened this issue Jul 16, 2014 · 0 comments

Comments

@jhaals
Copy link
Contributor

jhaals commented Jul 16, 2014

Hi!

There's currently no support for downloading modules from a custom v3 forge. All requests are made using the v1 API due to https://github.com/rodjek/librarian-puppet/blob/master/lib/librarian/puppet/source/forge.rb#L153

It would be awesome if librarian-puppet could support v3 forges that's not puppetlabs.com

I have a local patch where you can specify librarian-puppet install --use-v3-api
Line 153 in forge.rb would then be if uri.hostname =~ /\.puppetlabs\.com$/ || environment.use_v3_api

I just want to verify if that's a good approach before sending the PR.

carlossg added a commit that referenced this issue Jul 22, 2014
fix #237 add install flag for using the v3 forge api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant