Forge module version is ignored and support 1.x type versions

[carlossg]

Added the cucumber tests for both cases, tested on 3.0.1 and 2.7.14

Supersedes #56 and #45

[cprice404]

Thanks for submitting this @carlossg ! We've had this come up as an issue on at least two different puppet modules recently.

[craigtracey]

Yes, thanks @carlossg. We are also encountering this.

[dgoodlad]

+1; librarian-puppet was unusable with recent modules without this patch, but works great with it applied directly to 0.9.7.

[dgoodlad]

@rodjek What's your opinion of these changes?

It seems to me like the disconnect between the versioning style being promoted by Puppet Labs and that of Rubygems (and therefore of librarian) is growing. The 0.x style, and now the puppetlabs-apache module using a 0.5.0-rc1 style instead of 0.5.0.rc1 is just going to continue to bite users of puppet-librarian.

I did a quick hack, though it's not tied in very nicely, on top of this PR to start building some generic mappings back and forth between puppet/gem style version specs: dgoodlad@996eb9a . It feels like it might be the right direction to head...

Thoughts?

[patcon]

👍

[carlossg]

--version fixed in 9a291d8

[patcon]

❤️

Would it be too much trouble to work through PR's @carlossg?

[carlossg]

@patcon yeah, trying to rebase and match the multiple commits to the multiple issues