Skip to content

Commit

Permalink
fix: not sure why we need to disable sendfile
Browse files Browse the repository at this point in the history
  • Loading branch information
dhdaines committed Apr 17, 2024
1 parent ebc16ff commit 0a7c78b
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Launch the API
run: |
coverage run --parallel-mode \
-m gunicorn --worker-class uvicorn.workers.UvicornWorker -w 1 g2p.app:APP --no-sendfile --bind 127.0.0.1:5000 --daemon
-m gunicorn --worker-class uvicorn.workers.UvicornWorker -w 1 g2p.app:APP --bind 127.0.0.1:5000 --daemon
- name: Run dev suite
run: coverage run --parallel-mode run_tests.py dev
- name: Run test-studio
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ COPY Dockerfile /g2p
RUN pip3 install -e /g2p

# Comment this out if you just want to install g2p in the container without running the studio.
CMD gunicorn --worker-class uvicorn.workers.UvicornWorker -w 1 g2p.app:APP --no-sendfile --bind 0.0.0.0:8000
CMD gunicorn --worker-class uvicorn.workers.UvicornWorker -w 1 g2p.app:APP --bind 0.0.0.0:8000
2 changes: 1 addition & 1 deletion Procfile
Original file line number Diff line number Diff line change
@@ -1 +1 @@
web: gunicorn --worker-class uvicorn.workers.UvicornWorker -w 1 g2p.app:APP --no-sendfile
web: gunicorn --worker-class uvicorn.workers.UvicornWorker -w 1 g2p.app:APP
2 changes: 1 addition & 1 deletion g2p/tests/test_studio.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
minimal dev mode:
python run_studio.py
or robust server mode (*nix only, gunicorn does not work on Windows):
gunicorn --worker-class uvicorn.workers.UvicornWorker -w 1 g2p.app:APP --no-sendfile --bind 0.0.0.0:5000 --daemon
gunicorn --worker-class uvicorn.workers.UvicornWorker -w 1 g2p.app:APP --bind 0.0.0.0:5000 --daemon
"""

import sys
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ lock-filename = "requirements.txt"
pip-compile-verbose = false

[tool.hatch.envs.prod.scripts]
serve = "gunicorn --worker-class uvicorn.workers.UvicornWorker -w 1 g2p.app:APP --no-sendfile --bind 0.0.0.0:5000"
serve = "gunicorn --worker-class uvicorn.workers.UvicornWorker -w 1 g2p.app:APP --bind 0.0.0.0:5000"

[tool.hatch.envs.test]
features = [ "test" ]
Expand Down

0 comments on commit 0a7c78b

Please sign in to comment.