Fix win mapping with right length marker and avoid doubling it #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, some mappings have (out, in, rest), or even (something, out, in, rest), and that makes it quite confusing when reading the output of g2p show-mappings. So on printing, (i.e., in plain_mapping()), start with in, then out, then everything else.
The length marker in IPA is ː (\u02D0), not : (ascii colon) win-ipa to eng-ipa had a feeding problem, with "eː"->"eː" feeding "e"->"eː" and thus generating "eːː" in the eng-ipa output, and "EY ː" in the eng-arpabet output. Unit tests added for individual characters, but I have no words to test properly, so I'm doing the best I can with what I have... FIXES #100
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
==========================================
+ Coverage 90.18% 90.20% +0.02%
==========================================
Files 36 36
Lines 3291 3299 +8
==========================================
+ Hits 2968 2976 +8
Misses 323 323
Continue to review full report at Codecov.
|
roedoejet
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The length marker in IPA is ː (\u02D0), not : (ascii colon)
win-ipa to eng-ipa had a feeding problem, with
"eː"->"eː"feeding"e"->"eː"and thus generating"eːː"in the eng-ipa output, and"EY ː"inthe eng-arpabet output.
Unit tests added for individual characters, but I have no words to test
properly, so I'm doing the best I can with what I have...
FIXES #100