Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation with -std=gnu++11 #406

Closed
wants to merge 1 commit into from

Conversation

tfry-git
Copy link
Contributor

See #402

@lacklustrlabs
Copy link
Contributor

lacklustrlabs commented Dec 11, 2017

I wonder if we really need the #if __cplusplus >= 201103L tests.
http://www.stm32duino.com/viewtopic.php?f=3&t=1241&p=38520#p38520

C++17 has already been approved, so why struggle with C++03 or earlier versions?

@tfry-git
Copy link
Contributor Author

I suppose it depends which compilers we may still want to support. If we are all set to stick with C++11(or later) for good, a fix without standards version check is even more trivial. I don't mind if this request is rejected, I'd just like to get the issue fixed one way or another.

@stevstrong
Copy link
Collaborator

gnu11 was introduced without any fallback scenario.
So we don't need any ifdefs.

@tfry-git
Copy link
Contributor Author

Next attempt: #407

(Seems I can change the target branch to merge to, but not the source branch to merge form in a PR)

@tfry-git tfry-git closed this Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants