Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testscript: use unix.CloneFile on MacOs #222

Merged
merged 1 commit into from
May 5, 2023

Conversation

bep
Copy link
Contributor

@bep bep commented May 5, 2023

To fix unexpected errors of type:

[signal: killed]
FAIL: testscripts/myecho.txt:1: unexpected command failure

Fixes #200

@bep bep force-pushed the fix/unexpectedcommandfailuretake4 branch from 13809f4 to 63bcc78 Compare May 5, 2023 14:29
@bep bep changed the title Use unix.CloneFile on MacOs testscript: use unix.CloneFile on MacOs May 5, 2023
@bep bep force-pushed the fix/unexpectedcommandfailuretake4 branch from 63bcc78 to 992d813 Compare May 5, 2023 14:31
@mvdan
Copy link
Collaborator

mvdan commented May 5, 2023

Failed build, FYI - otherwise SGTM. cc @myitcv @rogpeppe

@bep bep force-pushed the fix/unexpectedcommandfailuretake4 branch from 992d813 to b96416d Compare May 5, 2023 15:28
@bep
Copy link
Contributor Author

bep commented May 5, 2023

@mvdan build should be fixed now (build constrains can be tricky to get right ...)

@bep bep force-pushed the fix/unexpectedcommandfailuretake4 branch from b96416d to bdcd084 Compare May 5, 2023 15:30
To fix unexpected errors of type:

```
[signal: killed]
FAIL: testscripts/myecho.txt:1: unexpected command failure
```

Fixes rogpeppe#200
@bep bep force-pushed the fix/unexpectedcommandfailuretake4 branch from bdcd084 to 4facded Compare May 5, 2023 15:30
Copy link
Collaborator

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM; merging relatively quickly since the issue is relatively severe for Mac users, and the fix being in master will allow for more testing.

@mvdan mvdan merged commit 44c3b86 into rogpeppe:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testscript: "signal: killed" exec errors on MacOS 12
2 participants